Docker: set cwd explicitly #8191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure is just a command check that changed, seems safe still 👍 |
| @@ -102,7 +102,7 @@ def __init__( | |||
| ): | |||
| self.command = command | |||
| self.shell = shell | |||
| self.cwd = cwd or os.getcwd() | |||
| self.cwd = cwd or '$HOME' | |||
There was a problem hiding this comment.
I wonder if we're depending on the old default somewhere... hopefully not.
There was a problem hiding this comment.
If we were, it would have been an error on our builders at least p:, we are expanding that var for people that aren't using docker.
There was a problem hiding this comment.
greped for .run(, we are setting the cwd explicitly on all of them. (.org and .com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make this the default in
readthedocs.org/readthedocs/doc_builder/environments.py
Line 105 in 611d35c