Search: little optimization when saving search queries #8132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check max 30 queries, in case there is a flood of queries. - Fetch project and version in one query. I think we can also remove the project relationship, and only have version, but maybe for later.
humitos
approved these changes
May 27, 2021
| @@ -169,33 +169,30 @@ def record_search_query(project_slug, version_slug, query, total_results, time_s | |||
|
|
|||
| # If a partial query exists, | |||
| # then just update that object. | |||
| for partial_query in partial_query_qs.iterator(): | |||
| max_queries = 30 | |||
There was a problem hiding this comment.
How did you come to this number? What does it mean as a user in the search context? Will it show only 30 results as maximum?
There was a problem hiding this comment.
It means that we will only search the latest 30 searches that have happened in the last 10 seconds in that project/version. Just a small protection in case we get flooded.
Check max 30 queries, in case there is a flood of queries.
There was a problem hiding this comment.
and this doesn't have anything to do with the search results a user gets, this code is to save in our db analytics about searches that a project has
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can also remove the project relationship,
and only have version, but maybe for later.