Sync versions: don't fetch/return all versions #8114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using this only for logging, retrieving all versions from the db and making an string from it may be expensive. This may be related to the OOM error, but hard to say. Didn't see anything else that may be causing this.
stsewd
commented
Apr 19, 2021
| self.assertEqual( | ||
| set(self.pip.versions.all().values_list('slug', flat=True)), | ||
| {'master', 'latest', 'stable', '0.8.1', '0.8', 'to_add'}, | ||
| ) |
There was a problem hiding this comment.
the other tests were already checking the versions from the db instead of the return value :)
ericholscher
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using this only for logging,
retrieving all versions from the db and making an string from it
may be expensive.
This may be related to the OOM error, but hard to say.
Didn't see anything else that may be causing this.