-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Improve documentation on contributing to documentation #8082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
681a3d3
add github UI instructions
cocobennett 524245c
add local instructions
cocobennett c2df1c4
remove periods to follow convention
cocobennett be428e5
link style markdown -> rst
cocobennett 5111243
enhance local instructions
cocobennett f87f74b
fix link syntax mistake
cocobennett ca58bd3
instructions without installing all of RTD
cocobennett 9fee53f
numbers to #
cocobennett 94dc3e9
working instructions for building documentation
cocobennett bb037a4
fix lint
cocobennett 6b6a640
fix file permissions
cocobennett fe39794
fix local setup issue with Mercurial
cocobennett 71274a0
remove tox instructions
cocobennett b4a8692
add image
cocobennett 94a1e40
move todo comment
cocobennett 780f639
python3.7->3.6
cocobennett 6fe163a
install autobuild and update instructions
cocobennett 2b5024a
autobuild
cocobennett 5f477e4
review edits
cocobennett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,32 +5,77 @@ As one might expect, | |
the documentation for Read the Docs is built using Sphinx and hosted on Read the Docs. | ||
The docs are kept in the ``docs/`` directory at the top of the source tree. | ||
|
||
.. TODO: expand this section explaining there the PR is automatically built and | ||
the author can visualize changes without installing anything on their system. | ||
However, if there is going to be periodic/bigger contributions, it may be a | ||
good idea to install the Sphinx requirements to build our docs. | ||
Contributing through the Github UI | ||
---------------------------------- | ||
|
||
If you're making small changes to the documentation, | ||
you can verify those changes through the documentation generated when you open a PR and can be accessed using the Github UI. | ||
|
||
#. click the checkmark next to your commit and it will expand to have multiple options | ||
|
||
#. right-click the "details" link next to the "docs/readthedocs.org:docs" item | ||
|
||
.. image:: /img/details_link.png | ||
|
||
#. navigate to the section of the documentation you worked on to verify your changes | ||
|
||
Contributing from your local machine | ||
------------------------------------ | ||
|
||
.. note:: | ||
|
||
You must use python 3.6 to generate the documentation. | ||
|
||
If you're making large changes to the documentation, | ||
you may want to verify those changes locally before pushing upstream. | ||
|
||
#. clone the `readthedocs.org` repository: | ||
|
||
.. prompt:: bash | ||
|
||
git clone --recurse-submodules https://github.com/readthedocs/readthedocs.org/ | ||
|
||
#. install documentation requirements | ||
|
||
.. prompt:: bash | ||
|
||
cd readthedocs.org | ||
pip install -r requirements/testing.txt | ||
pip install -r requirements/docs.txt | ||
Comment on lines
+43
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't we walk the user through the steps to create a virtualenv for this? |
||
|
||
#. build the documents | ||
|
||
.. prompt:: bash | ||
|
||
cd docs | ||
make livehtml | ||
|
||
#. the documents will be available at http://127.0.0.1:4444/ and will rebuild each time you edit and save a file. | ||
|
||
Guidelines | ||
---------- | ||
|
||
Please follow these guidelines when updating our docs. | ||
Let us know if you have any questions or something isn't clear. | ||
|
||
The brand | ||
--------- | ||
^^^^^^^^^ | ||
|
||
We are called **Read the Docs**. | ||
The *the* is not capitalized. | ||
|
||
We do however use the acronym **RTD**. | ||
|
||
Titles | ||
------ | ||
^^^^^^ | ||
|
||
For page titles, or Heading1 as they are sometimes called, we use title-case. | ||
|
||
If the page includes multiple sub-headings (H2, H3), | ||
we usually use sentence-case unless the titles include terminology that is supposed to be capitalized. | ||
|
||
Content | ||
------- | ||
^^^^^^^ | ||
|
||
* Do not break the content across multiple lines at 80 characters, | ||
but rather break them on semantic meaning (e.g. periods or commas). | ||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need
requirements/testing.txt
to work on the docs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment they're needed, yes. Otherwise some dependencies are missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(It's up to debate whether we should organize our dependencies in a better way, or improve the naming of the requirements files, see #7037 (comment))