Conda: protect against None when appending core requirements #8077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrojuanlu
approved these changes
Apr 8, 2021
humitos
approved these changes
Apr 8, 2021
| @@ -615,7 +615,7 @@ def _append_core_requirements(self): | |||
|
|
|||
| for item in dependencies: | |||
| if isinstance(item, dict) and 'pip' in item: | |||
| pip_requirements.extend(item.get('pip', [])) | |||
| pip_requirements.extend(item.get('pip') or []) | |||
There was a problem hiding this comment.
@stsewd the comment you added in the description of the PR is a good one. "pip can be None" says less than the description, where you explained the reason of pip being None which adds good context to the problem.
stsewd
force-pushed
the
protect-agains-none
branch
from
567493d to
bfa0e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipcan be defined as https://github.com/LFPy/LFPy/blob/b38146fb94dc933f5c40afd872369502031b9537/doc/environment.yml#L16Ref https://sentry.io/organizations/read-the-docs/issues/2317539725/?environment=production&project=148442&referrer=alert_email