Skip to content

Python Environment: Use latest theme on all sphinx versions #8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Python Environment: Use latest theme on all sphinx versions #8073

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0eadf5
Python Environment: Use latest theme on all sphinx versions
Blendify Apr 6, 2021
8fe569d
Revert cp/paste error
Blendify Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions readthedocs/doc_builder/python_environments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,12 +377,15 @@ def install_core_requirements(self):
positive='sphinx',
negative='sphinx<2',
),
# If defaulting to Sphinx 2+, we need to push the latest theme
# release as well. `<0.5.0` is not compatible with Sphinx 2+
# When using sphinx<2 use a theme version that is supported.
# While sphinx-rtd-theme 0.5.2 supports sphinx<2 and sphinx>2,
# support for sphinx<2 will be removed in the future.
# In that case we may need to modify the versions here
# or handle sphinx compatibility in the theme.
self.project.get_feature_value(
Feature.USE_SPHINX_LATEST,
positive='sphinx-rtd-theme',
negative='sphinx-rtd-theme<0.5',
negative='sphinx-rtd-theme<0.6',
),
self.project.get_feature_value(
Feature.USE_SPHINX_RTD_EXT_LATEST,
Expand Down