Skip to content

RemoteRepository: Improvements to sync_vcs_data.py script #8017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2021
Merged

RemoteRepository: Improvements to sync_vcs_data.py script #8017

merged 2 commits into from
Mar 15, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 15, 2021

  • Add --logged-in-days-ago argument to resync only users who logged in some days ago
  • Add --skip-revoked-users argument to avoid resyncing users we already known they revoked our access token

@humitos humitos requested review from saadmk11 and a team March 15, 2021 11:42
@humitos humitos force-pushed the humitos/sync-vcs-script branch from 950f55c to f5e01a6 Compare March 15, 2021 11:43
saadmk11
saadmk11 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@saadmk11 saadmk11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great. I really like the way you are using sentry's data to filter revoked users 💯

@humitos humitos merged commit 20549f5 into remote-repository-normalization Mar 15, 2021
@humitos humitos deleted the humitos/sync-vcs-script branch March 15, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadmk11 saadmk11 saadmk11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @saadmk11