Remove json field from RemoteRepositoryRelation and RemoteOrganizationRelation model #7993
Conversation
readthedocs/oauth/services/gitlab.py
Outdated
| try: | ||
| repo_id = json.loads(project.remote_repository.json).get('id') | ||
| repo_id = project.remote_repository.remote_id | ||
| except Exception: |
There was a problem hiding this comment.
We could probably remove the try/except clause here as well.
There was a problem hiding this comment.
if the project was imported manually it would throw an exception as stated here.
There was a problem hiding this comment.
He, I didn't read the following line.
However, the previous case would have failed because the json.loads would have failed. Now, accessing remote_id will return just None and won't fail. I think we should check if project.remote_repository.remote_id is None instead of the try/except, right?
There was a problem hiding this comment.
In this case the project.remote_repository wont exist and throw RemoteRepositroy.DoesNotExist Exception.
There was a problem hiding this comment.
Good point! Can we catch that exception here then instead of the generic Exception?
This PR removes
jsonfield from RemoteRepositoryRelation and RemoteOrganizationRelation model as thejsonfield is no longer required or used in the codebase, we are storing theremote_idseparately in another field.