Skip to content

Upgrade postgres-client to v12 in Docker image #7967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 1, 2021

This is required to have a fully compatible client with the new features from
v12, which is the one that we are using on our docker setup, but also in
production.

As a example, the following command fails with the old client:

psql (10.15 (Ubuntu 10.15-0ubuntu0.18.04.1), server 12.5 (Debian 12.5-1.pgdg100+1))
WARNING: psql major version 10, server major version 12.
         Some psql features might not work.
Type "help" for help.

docs_db=# \d oauth_remoterepository
ERROR:  column c.relhasoids does not exist
LINE 1: ...riggers, c.relrowsecurity, c.relforcerowsecurity, c.relhasoi...

(note the differences between client and server versions)

We will need to update this also in our production images (cc @ericholscher we may need this to run DB queries from dbshell for the constraints)

Required by #7949 (comment)

This is required to have a fully compatible client with the new features from
v12, which is the one that we are using on our docker setup, but also in
production.

As a example, the following command fails with the old client:

psql (10.15 (Ubuntu 10.15-0ubuntu0.18.04.1), server 12.5 (Debian 12.5-1.pgdg100+1))
WARNING: psql major version 10, server major version 12.
         Some psql features might not work.
Type "help" for help.

docs_db=# \d oauth_remoterepository
ERROR:  column c.relhasoids does not exist
LINE 1: ...riggers, c.relrowsecurity, c.relforcerowsecurity, c.relhasoi...

(note the differences between client and server versions)

We will need to update this also in our production images.
@ericholscher
Copy link
Member

Hrm, not sure the best way to update this in prod. Is it not possible with a PPA from ubuntu, or should we use a similar approach here?

@humitos
Copy link
Member Author

humitos commented Mar 2, 2021

@ericholscher I didn't find a PPA from Ubuntu and as this PPA is the official from PostgreSQL itself, I thought we can trust on it. I'd say to follow the same steps than here for now until we upgrade to Ubuntu 20.04 LTS which this won't be required anymore.

@humitos
Copy link
Member Author

humitos commented Mar 4, 2021

I'm merging this PR and I will see if I can try to open a new PR for servers. We can discuss the approach there.

@humitos humitos merged commit 01adfc6 into master Mar 4, 2021
@humitos humitos deleted the humitos/docker-psql-client branch March 4, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants