Router PRs builds to last queue where a build was executed #7912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, every time a PR is triggered to be built we are building it under our build:large queue. This is because we have no data about this version and we build them on build:large. This commit checks where the last build was built when a PR is triggered to be built and use that queue to build the PR. Closes #7815
humitos
force-pushed
the
humitos/route-pr-smarty
branch
from
a7bf91f to
ca600bc
Compare
humitos
commented
Feb 16, 2021
Comment on lines
+98
to
+99
| if version.type == EXTERNAL: | ||
| for build in last_builds.iterator(): |
There was a problem hiding this comment.
I got confused here. This is wrong.
We need to find out the last_builds for the default Version here. The Version to be built (external) has no builds at all if it's new. I'll open a new PR to fix this.
humitos
added a commit
that referenced
this pull request
Feb 18, 2021
When a build for an external version is triggered, we find the the last build for the default version and use the same queue for this version. This should make the build to always succeed when it's merged into the default version since it's using the same build queue. I thought this was fixed originally in #7912 but that PR was wrong.
humitos
added a commit
that referenced
this pull request
Feb 18, 2021
When a build for an external version is triggered, we find the the last build for the default version and use the same queue for this version. This should make the build to always succeed when it's merged into the default version since it's using the same build queue. I thought this was fixed originally in #7912 but that PR was wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, every time a PR is triggered to be built we are building it under our
build:large queue. This is because we have no data about this version and we
build them on build:large.
This commit checks where the last build was built when a PR is triggered to be
built and use that queue to build the PR.
Closes #7815