Fix conf.py for external versions #7845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcs_url is making a call to the db somewhere.
ericholscher
approved these changes
Jan 19, 2021
humitos
reviewed
Jan 19, 2021
| @@ -170,6 +174,7 @@ def get_config_params(self): | |||
| 'downloads': downloads, | |||
| 'subproject_urls': subproject_urls, | |||
| 'build_url': build_url, | |||
| 'vcs_url': vcs_url, | |||
There was a problem hiding this comment.
Why don't we pass always self.version.vcs_url instead only when it's external? I think that will simplify code reading and thinking about why.
Otherwise, we could have a comment in the previous if.
There was a problem hiding this comment.
this is only used in external versions currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version.vcs_url shouldn't have access to the db for external versions. The value was being evaluated for all aversions