Skip to content

Footer: remove absolute_uri #7758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Footer: remove absolute_uri #7758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions readthedocs/api/v2/views/footer_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,8 @@ class BaseFooterHTML(APIView):

- project
- version
- page: Sphinx's page name, used for path operations,
like change between languages (deprecated in favor of ``absolute_uri``).
- absolute_uri: Full path with domain, used for path operations.
- page: Sphinx's page name (name of the source file),
used to build the "edit on" links.
- theme: Used to decide how to integrate the flyout menu.
- docroot: Path where all the source documents are.
Used to build the ``edit_on`` URL.
Expand Down
1 change: 0 additions & 1 deletion readthedocs/core/static-src/core/js/doc-embed/footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ function init() {
project: rtd['project'],
version: rtd['version'],
page: rtd['page'],
absolute_uri: window.location.href,
theme: rtd.get_theme_name(),
format: "jsonp",
};
Expand Down
2 changes: 1 addition & 1 deletion readthedocs/core/static/core/js/readthedocs-doc-embed.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions readthedocs/rtd_tests/tests/test_footer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,8 +448,7 @@ def setUp(self):

self.url = (
reverse('footer_html') +
f'?project={self.pip.slug}&version={self.latest.slug}&page=index&docroot=/docs/' +
'&absolute_uri=https://pip.readthedocs.io/en/latest/index.html'
f'?project={self.pip.slug}&version={self.latest.slug}&page=index&docroot=/docs/'
)
self.host = 'pip.readthedocs.io'

Expand Down