Integrations: allow to pass more data about external versions #7692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was extracted from #7664
stsewd
commented
Nov 23, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ericholscher
approved these changes
Jul 15, 2021
| }, | ||
| "base": { | ||
| "ref": "master", | ||
| }, |
There was a problem hiding this comment.
We don't seem to be testing any of these additional fields?
| except KeyError: | ||
| raise ParseError('Parameters "id" and "iid" are required') | ||
| raise ParseError('Invalid payload') |
There was a problem hiding this comment.
This is a worse error message, we should clarify why it's invalid.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need more data from the PR like the source and base branch, also this makes it more explicit about passing the PR number as verbose name.
This was extracted from #7664