Allow to add additional binds to Docker build container #7684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Nov 23, 2020
Sometimes it might be necessary to add additional binds to the build
container, e.g. to add SSH keys for the docs user to clone private
repositories or for caches. These additional binds can be specified
as field in settings:
RTD_DOCKER_ADDITIONAL_BINDS = {
'/home/docs/.ssh': {
'bind': '/home/docs/.ssh',
'mode': 'ro',
}
}
fabianmp
force-pushed
the
additional-binds
branch
from
7accaed to
53262e5
Compare
|
thanks for the review, I have updated the commit with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it might be necessary to add additional binds to the build
container, e.g. to add SSH keys for the docs user to clone private
repositories or for caches. These additional binds can be specified
as field in settings:
DOCKER_ADDITIONAL_BINDS = {
'/home/docs/.ssh': {
'bind': '/home/docs/.ssh',
'mode': 'ro',
}
}