External versions: delete after 3 months of being merged/closed #7678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are deleting external versions when they are closed, but their docs remain in storage. With this change we mark them as inactive instead. Later a task will delete all external versions that are inactive and their last activity was from 3 months ago. Before being deleted the status is updated to link to the build page instead (the build will be deleted currently, but I'm changing that in another PR). Ref #7674
stsewd
force-pushed
the
delete-external-after-x-days
branch
from
827c9d2 to
657f4da
Compare
ericholscher
approved these changes
Nov 18, 2020
| @@ -163,3 +169,40 @@ def archive_builds_task(days=14, limit=200, include_cold=False, delete=False): | |||
| build.commands.all().delete() | |||
| except IOError: | |||
| log.exception('Cold Storage save failure') | |||
|
|
|||
|
|
|||
| def delete_inactive_external_versions(limit=200, days=30 * 3): | |||
There was a problem hiding this comment.
Not sure if we really need a limit here -- are we worried about something specific with it?
There was a problem hiding this comment.
After 90 days, we may have a lot of versions to delete (or maybe not? We don't know how many PRs are open in a day), the task may be running for a long period of time, but not sure if that's a problem, let me know if you want me to remove it.
There was a problem hiding this comment.
I think its fine to have a limit, I guess. We can adjust if we need to later.
Co-authored-by: Eric Holscher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are deleting external versions
when they are closed, but their docs remain in storage.
With this change we mark them as inactive instead.
Later a task will delete all external versions that are inactive
and their last activity was from 3 months ago.
The task is run once every day (not sure if this should run more frequently).
Before being deleted the status is updated to link to the build page
instead (the build will be deleted currently, but I'm changing that in
another PR).
Ref #7674