Automation rules: add delete version action #7644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we automatically delete inactive versions when they are deleted from the repository. If the version is active we keep it, and users must deactivate it manually. With this rule users can automate that. Default versions can't deactivate it, users must change the default version first. This is the only rule that is run when a version is deleted. Closes #7637
stsewd
force-pushed
the
automation-rules-delete
branch
from
8aa3b58 to
beec626
Compare
humitos
requested changes
Nov 11, 2020
There was a problem hiding this comment.
This looks like a good feature.
I'd like to keep delete_versions_from_db as it was and add a helper or similar to "get versions deleted from remote repository that we still have in the DB" because I found it super confusing to be added in the same function that effectively delete versions from the DB.
Besides that, I left some other small comments to consider.
humitos
approved these changes
Nov 11, 2020
Co-authored-by: Manuel Kaufmann <[email protected]>
…thedocs.org into automation-rules-delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we automatically delete inactive versions
when they are deleted from the repository.
If the version is active we keep it,
and users must deactivate it manually.
With this rule users can automate that.
Default versions can't deactivate it,
users must change the default version first.
This is the only rule that is run when a version is deleted.
Closes #7637