Search: exclude some fields from source results #7640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully make search a little faster, we don't make use of these fields in the serializer. The big ones are sections and domains, we will be fetching all of them per each page, instead of just the ones that matched. Also fixed a bug, we were omitting the description from the project in the serializer.
stsewd
force-pushed
the
search-exclude
branch
from
f8091cc to
38cb041
Compare
ericholscher
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully make search a little faster,
we don't make use of these fields in the serializer.
The big ones are sections and domains,
we will be fetching all of them per each page,
instead of just the ones that matched.
Also fixed a bug, we were omitting the description from the project in
the serializer.
ref #7349