Reserve 1Gb for Application Memory #7618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have noticed some strange behavior when trying to `create_container` and `remove_container` using the Docker API. For some reason we started getting ReadTimeout and I'm supposing that our Docker daemon has been restarted (because of OOM) or in a dumb state. This commit increases from 750 to 1000 Mb of RAM memory reserved for our application and OS processes. The user will get 7000Mb instead of 7200Mb in build-large instances and in build-default instances they will get 2400 intead of 2700Mb.
ericholscher
approved these changes
Nov 2, 2020
| @@ -495,7 +495,7 @@ def _get_docker_memory_limit(self): | |||
| "free -m | awk '/^Mem:/{print $2}'", | |||
| shell=True, | |||
| )) | |||
| return total_memory, round(total_memory - 750, -2) | |||
| return total_memory, round(total_memory - 1000, -2) | |||
There was a problem hiding this comment.
This should probably be a constant, or at least have a comment explaining the logic.
There was a problem hiding this comment.
Agree. I'm merging it for now so it goes out tomorrow, tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed some strange behavior when trying to
create_containerandremove_containerusing the Docker API. For some reason we started gettingReadTimeout and I'm supposing that our Docker daemon has been restarted (because
of OOM) or in a dumb state.
This commit increases from 750 to 1000 Mb of RAM memory reserved for our
application and OS processes.
The user will get 7000Mb instead of 7200Mb in build-large instances and
in build-default instances they will get 2400 intead of 2700Mb.
Reference: #7583 (comment)