Catch requests.exceptions.ReadTimeout when removing container
#7617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are already catching other similar exceptions here, log them and continuing with the build. However, there is now another similar exception `requests.exceptions.ReadTimeout` that's causing some builds to fail. This commit catchs this exceptions and makes the build to behave in the same way as we are doing with similar exceptions.
stsewd
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are already catching other similar exceptions here, log them and continuing
with the build. However, there is now another similar exception
requests.exceptions.ReadTimeoutthat's causing some builds to fail.This commit catchs this exceptions and makes the build to behave in the same way
as we are doing with similar exceptions.
Related #7583 (comment)