-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update mkdocs default version #7546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Everything looking good in local testing. The changelog doesn't mention anything breaking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems still broken:
before: https://docs.openra.net/en/latest/release/lua/
after: https://openhv.readthedocs.io/en/latest/release/lua/
Additionally the table of contents is partly gone.
@Mailaender if you are already using the latest version of mkdocs you should report those problems to mkdocs, this isn't related to rtd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this affect to all the builds that are not pinning mkdocs? I think what we want here is a feature flag that uses mkdocs<1.2
only for new projects.
I don't think we have a plan to update build dependencies that we install by default, but if we don't, we should so we apply it every time we need it. Like this case.
Yes, but this update isn't going to break the builds. Is just a minor update. |
This removes python 3 support, along with a number of other large changes: https://www.mkdocs.org/about/release-notes/#other-changes-and-additions-to-version-11 -- this will definitely break things for people. |
They really shouldn't have snug that into a point release. |
I think we can add this after #7524 is merged |
Everything looking good in local testing.
The changelog doesn't mention anything breaking.
ref #7539