Skip to content

Builds: always install latest version of our sphinx extension #7542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 6, 2020

I'm not removing the feature,
as it can be used in the future.

@stsewd
Copy link
Member Author

stsewd commented Oct 6, 2020

I have sample >20K projects with this flag, I'll put more tomorrow and see how it goes during the week.

@stsewd
Copy link
Member Author

stsewd commented Oct 13, 2020

The sample is >50K now

ericholscher
ericholscher previously approved these changes Oct 20, 2020
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, we should try not to need this in the future, and it's definitely good getting everyone on the same version.

@ericholscher ericholscher dismissed their stale review October 20, 2020 17:15

Needs change

I'm not removing the feature,
as it can be used in the future.
@stsewd stsewd force-pushed the install-latest-ext branch from c712ce4 to 47eaa30 Compare October 20, 2020 19:20
@stsewd stsewd requested a review from ericholscher October 20, 2020 19:20
@stsewd stsewd merged commit a81d82e into master Oct 22, 2020
@stsewd stsewd deleted the install-latest-ext branch October 22, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants