Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Initial Modeling with Through Model and Data Migration for RemoteRepository Model #7536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Initial Modeling with Through Model and Data Migration for RemoteRepository Model #7536
Changes from 6 commits
307a1cb
7bd1a5f
9476a36
1bd03c7
c3592eb
c6699fb
bf5c6b1
d90ecad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add the
remote_id
field here as well and populate it with theid
that it's inremoterepository.json
.If we are not doing it in this PR, we should create an issue to keep track of. We will need it to remove the usage of
full_name
in many places.I created a project at https://github.com/orgs/readthedocs/projects/74?add_cards_query=is%3Aopen where we can track all of the related PR and issues. Let me know if you have permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sure, maybe we can do data migration for this and #7536 (comment) first.
This PR will remove the json field from
RemoteRepository
model so I think its better to do this first in a different PR or make it the first migration on this PR.@humitos What do you say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@humitos I can not see some of the cards maybe they are from a private repo or something, otherwise it all good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to rename this model to something like
RemoteRepositoryRelation
because we will also need a relation model forRemoteOrganization
as well and we will have conflicting names.Does it make sense to add make
remoterepository
field nullable and addremoteorganization
field as well to thisRemoteRelation
model and use it for both? It seems it's exactly the same data butRemoteOrganization
does not hasadmin
field.