Use permissions (project and group) for RemoteRepository.admin on GitLab
#7479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When syncing `RemoteRepository` in GitLab we were only checking if the user was the owner of the project, but we weren't checking for permissions given by belonging to a group. This commit makes usage of 40 (maintainer) and 50 (owner) permission levels to check these permissions granted by being part of a group.
stsewd
reviewed
Sep 14, 2020
readthedocs/oauth/services/gitlab.py
Outdated
| # https://docs.gitlab.com/ee/api/access_requests.html | ||
| # https://gitlab.com/help/user/permissions | ||
| project_access = fields.get('permissions', {}).get('project_access', {}) | ||
| project_access_level = project_access.get('access_level', 0) if project_access else 0 |
There was a problem hiding this comment.
Looks like project access already defaults to an empty dict, this makes sense gitlab can set this to None. Same for group_access_level
Suggested change
| project_access_level = project_access.get('access_level', 0) if project_access else 0 | |
| project_access_level = project_access.get('access_level', 0) |
There was a problem hiding this comment.
I was bitten by this already, where project_access can be None. The if is to avoid bypass that case
stsewd
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing
RemoteRepositoryin GitLab we were only checking if the user wasthe owner of the project, but we weren't checking for permissions given by
belonging to a group.
This commit makes usage of 40 (maintainer) and 50 (owner) permission levels to
check these permissions granted by being part of a group.
Closes #7475