ES: update dependencies #7408
ES: update dependencies #7408
Conversation
Getting ready to upgrade to the latest version
There was a problem hiding this comment.
Code changes look good to me!
I tested this locally and it failed when performing a search from the dashboard: http://community.dev.readthedocs.io/search/?q=sphinx&type=file
Also, making a search from the homepage did work but it didn't show any result when searching http://community.dev.readthedocs.io/search/?q=sphinx
Am I missing something to test this properly? I did upgrade my ES to 6.5.4
|
@humitos this isn't ready for review, I haven't tested it locally yet. |
|
I tested this locally, is working. @humitos make sure you are installing the new deps in a clean environment, and also that search was working previously. |
stsewd
removed
the
PR: work in progress
| @@ -1,7 +1,7 @@ | |||
| import logging | |||
|
|
|||
| from django.conf import settings | |||
| from django_elasticsearch_dsl import DocType, Index, fields | |||
| from django_elasticsearch_dsl import Document, Index, fields | |||
There was a problem hiding this comment.
I'm curious if we're getting much value from the django integration here. It might make sense to look into just using the elasticsearch_dsl directly. I think we've disabled most of the Django-specific integration, so that might make our code easier to manage and a lot more explicit.
There was a problem hiding this comment.
Yeah, I saw that too. The main feature of the django integration is that it syncs the ES index when the models change, but we don't make use of that. I'll make a note.
|
@ericholscher this update will change the response of the old API ( |
|
@stsewd I think we are safe to deploy it now. I think a week is plenty of time 👍 |
|
What exactly is changing with the old API? |
Getting ready to upgrade to the latest version
I read the whole commit history from es_dsl follow the changes, so hopefully didn't miss anything :D I still need to double check django_es_dsl and test this locally.
Closes #6309
ref #5620