External providers: better logging for GitLab #7385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Aug 13, 2020
| 'GitLab project does not exist or user does not have ' | ||
| 'permissions: project=%s', | ||
| project, | ||
| 'GitLab project does not exist or user does not have permissions: ' |
There was a problem hiding this comment.
We should probably make sure our logging is consistent here across all providers. I've definitely wanted better logging here in the past, so 👍 on improvements.
There was a problem hiding this comment.
ha, looks like github was already logging this information, and more, I have updated this pr to match both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #7370