Skip to content

Remove DEDUPLICATE_BUILDS feature flag #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove DEDUPLICATE_BUILDS feature flag #7306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions readthedocs/core/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,6 @@ def prepare_build(
state=BUILD_STATE_TRIGGERED,
).count() > 1

if not project.has_feature(Feature.DEDUPLICATE_BUILDS):
log.debug('Skipping deduplication of builds. Feature not enabled. project=%s', project.slug)
skip_build = False

if skip_build:
# TODO: we could mark the old build as duplicated, however we reset our
# position in the queue and go back to the end of it --penalization
Expand Down
5 changes: 0 additions & 5 deletions readthedocs/projects/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1549,7 +1549,6 @@ def add_features(sender, **kwargs):
STORE_PAGEVIEWS = 'store_pageviews'
SPHINX_PARALLEL = 'sphinx_parallel'
USE_SPHINX_BUILDERS = 'use_sphinx_builders'
DEDUPLICATE_BUILDS = 'deduplicate_builds'
USE_SPHINX_RTD_EXT_LATEST = 'rtd_sphinx_ext_latest'
DEFAULT_TO_FUZZY_SEARCH = 'default_to_fuzzy_search'
INDEX_FROM_HTML_FILES = 'index_from_html_files'
Expand Down Expand Up @@ -1662,10 +1661,6 @@ def add_features(sender, **kwargs):
USE_SPHINX_BUILDERS,
_('Use regular sphinx builders instead of custom RTD builders'),
),
(
DEDUPLICATE_BUILDS,
_('Mark duplicated builds as NOOP to be skipped by builders'),
),
(
USE_SPHINX_RTD_EXT_LATEST,
_('Use latest version of the Read the Docs Sphinx extension'),
Expand Down
6 changes: 0 additions & 6 deletions readthedocs/rtd_tests/tests/test_builds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,12 +763,6 @@ def setUp(self):
project=self.project
)

get(
Feature,
feature_id=Feature.DEDUPLICATE_BUILDS,
projects=[self.project],
)

def test_trigger_duplicated_build_by_commit(self, update_docs_task):
"""
Trigger a build for the same commit twice.
Expand Down