Install latest version of setuptools #7290
Conversation
|
I don't know, feels safe to upgrade that package. @readthedocs/core thoughts on using a feature flag for a while? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
humitos
dismissed
their stale review
I'm dismissing my own review here. I think the right path to move forward here is to add a feature flag with future_default_true=True (#7524)
|
I think this is another "we need to figure out what to do with default versions" issue. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stsewd
force-pushed
the
use-latest-setuptools
branch
from
2ba36a4 to
236bf6a
Compare
|
This is under a feature flag now |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
| cmd = pip_install_cmd + [pip_version, setuptools_version] | ||
| self.build_env.run( | ||
| *cmd, bin_path=self.venv_bin(), cwd=self.checkout_path | ||
| ) |
There was a problem hiding this comment.
We are changing where we install setuptools here.
Now we are installing it together with pip as the first command we executed. Before, we were installing it together with our own dependencies. I don't think this is something bad, but definitely a change that may break in a random way 🙃
It makes sense to be installed with pip to me; but we should keep an eye on this.
Closes #7241
We have experienced other issues in the past bc of using an outdated version of setuptools too