CI: fix linter #7261
Merged
CI: fix linter #7261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter is failing for some dependency with isort somewhere. The latest version of prospector already pins the compatible versions of its dependencies.
humitos
approved these changes
Jul 7, 2020
ericholscher
approved these changes
Jul 7, 2020
| else: | ||
| self._populate_from = populate_from | ||
|
|
||
| self._populate_from = populate_from |
There was a problem hiding this comment.
I really don't like this linter setting -- I find the else statement much more explicit :(
There was a problem hiding this comment.
I'm fine with both styles. We can disable that check if we want
| return value | ||
| # SSH cloning and ``[email protected]:user/project.git`` | ||
| elif self.re_git_user.search(value) or url.scheme in private_schemes: | ||
| if self.re_git_user.search(value) or url.scheme in private_schemes: |
There was a problem hiding this comment.
I don't particularly like this linter change either. It feels vaguely correct, but requires reading all of the if statements to know if they properly raise or return :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linter is failing for some dependency with isort somewhere.
The latest version of prospector already pins the compatible versions of its dependencies.
This requires readthedocs/common#65