-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Search: implement stable API #7255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
84fd606
Use serializers for API
stsewd 7c62b2d
Update docs
stsewd 2c9cc63
Fix
stsewd bd25004
Rename docstring to content
stsewd a27efa1
Update js
stsewd 8ae8b09
Fix tests
stsewd 3305e8c
Merge branch 'master' into search-stable-api
stsewd 4ae54f8
Update tests
stsewd 271ea0e
Merge branch 'master' into search-stable-api
stsewd 8556598
Apply suggestions from code review
stsewd b78ea13
Merge branch 'search-stable-api' of github.com:readthedocs/readthedoc…
stsewd 96c9f44
Update readthedocs/core/static-src/core/js/doc-embed/search.js
stsewd 2d7f813
Merge branch 'search-stable-api' of github.com:readthedocs/readthedoc…
stsewd 835e79d
Refactor from review
stsewd 87619fb
Refactor js
stsewd f46dd4f
Use another endpoint
stsewd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving this warning since the response will change when we start returning relative paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should do the relative path work in another PR after merging this one, before shipping it? Seems nice to get it all done together if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can start working in another PR