Search: improve parser #7233
Merged
Search: improve parser #7233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make the parser more general and match #7232 (also, one bug fix). - Try the main tag before trying the first h1 - Always inspect all headers till 2 levels (this removes the need for the special case from Sphinx, where the h tag is inside a div) - `_parse_content` now not only removes all new line chars, but it also reduces multiple spaces into one. - Remove elements with the search role in addition to the navigation role. - The headerlink class doesn't need to be inside an `a` tag. - Fix bug where calling .text() over a text node will return empty. (I was able to catch this one now that we are checking till 2 levels)
stsewd
commented
Jun 25, 2020
| @@ -6,7 +6,7 @@ | |||
| { | |||
| "id": "mkdocs", | |||
| "title": "MkDocs", | |||
| "content": "Project documentation with\u00a0Markdown." | |||
| "content": "Project documentation with Markdown." | |||
There was a problem hiding this comment.
No more weird chars now that we are stripping all white spaces :D
Now that we prioritizes the main tag as main node, the main node from the mkdocs material theme is more wide.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ericholscher
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the parser more general and match
#7232
(also, one bug fix).
the special case from Sphinx, where the h tag is inside a div)
_parse_contentnow not only removes all new line chars, but it alsoreduces multiple spaces into one.
role.
atag.(I was able to catch this one now that we are checking till 2 levels)
This doesn't change the current indexing, maybe we will be indexing more content if we had a top text node (calling .text() would have returned empty).