Skip to content

Make RemoteRepository.full_name db_index=True #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2020
Merged

Make RemoteRepository.full_name db_index=True #7231

merged 1 commit into from
Jun 30, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 24, 2020 •
edited
Loading

We are going to use this field a lot to check GitHub permissions over these repositories and we want to make this queries faster.

NOTE: it's probably better to fake this migration and create the index manually with CONCURRENTLY to avoid locking the table. See https://realpython.com/create-django-index-without-downtime/

@humitos
Make RemoteRepository.full_name db_index=True
5e3ec04 
We are going to use this field a lot to check GitHub permissions over these
repositories and we want to make this queries faster.
@humitos humitos requested review from ericholscher and a team June 24, 2020 16:43
ericholscher
ericholscher approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an obviously useful change. I worry a bit about the migration, but it should hopefully be fine :/

@humitos humitos merged commit 364ef85 into master Jun 30, 2020
@humitos humitos deleted the humitos/remoterepository-full-name-db-index branch June 30, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @ericholscher