Add ability to rebuild a specific build

readthedocs/builds/views.py

@@ -54,14 +54,33 @@ def post(self, request, project_slug):
             return HttpResponseForbidden()
 
         version_slug = request.POST.get('version_slug')
+        commit = request.POST.get('commit')
+        build_pk = request.POST.get('build_pk')
+
         version = get_object_or_404(
-            self._get_versions(project),
+            # Don't filter by internal/external here so we can build all versions
+            Version.objects.public(self.request.user),
             slug=version_slug,
         )
 
+        # Set either the build or None
+        build = version.builds.filter(pk=build_pk).first()
+
+        if build:
+
+            log.info(
+                'Rebuilding build. project=%s version=%s commit=%s build=%s',
+                project.slug,
+                version.slug,
+                commit,
+                build.pk
+            )
+
         update_docs_task, build = trigger_build(
             project=project,
             version=version,
+            build=build,
+            commit=commit,
         )
         if (update_docs_task, build) == (None, None):
             # Build was skipped

readthedocs/core/utils/__init__.py

@@ -1,5 +1,6 @@
 """Common utilty functions."""
 
+from datetime import datetime
 import errno
 import logging
 import os
@@ -17,7 +18,6 @@
     BUILD_STATUS_PENDING,
     EXTERNAL,
 )
-from readthedocs.doc_builder.constants import DOCKER_LIMITS
 from readthedocs.projects.constants import CELERY_LOW, CELERY_MEDIUM, CELERY_HIGH
 from readthedocs.doc_builder.exceptions import BuildMaxConcurrencyError
 
@@ -64,6 +64,7 @@ def broadcast(type, task, args, kwargs=None, callback=None):  # pylint: disable=
 def prepare_build(
         project,
         version=None,
+        build=None,
         commit=None,
         record=True,
         force=False,
@@ -85,16 +86,14 @@ def prepare_build(
     :rtype: tuple
     """
     # Avoid circular import
-    from readthedocs.builds.models import Build
+    from readthedocs.builds.models import Build, BuildCommandResult
     from readthedocs.projects.models import Project, Feature
     from readthedocs.projects.tasks import (
         update_docs_task,
         send_external_build_status,
         send_notifications,
     )
 
-    build = None
-
     if not Project.objects.is_active(project):
         log.warning(
             'Build not triggered because Project is not active: project=%s',
@@ -112,7 +111,21 @@ def prepare_build(
         'commit': commit,
     }
 
-    if record:
+    if build:
+        build.state = BUILD_STATE_TRIGGERED
+        build.success = True
+        build.commit = commit
+        build.commands.all().delete()
+        build.save()
+        kwargs['build_pk'] = build.pk
+
+        # Show a step in the UI that the build is being rebuilt
+        BuildCommandResult.objects.create(
+            build=build, command='Rebuilding build', exit_code=0,
+            start_time=datetime.utcnow(), end_time=datetime.utcnow(),
+        )
+
+    if record and not build:
         build = Build.objects.create(
             project=project,
             version=version,
@@ -197,7 +210,7 @@ def prepare_build(
     )
 
 
-def trigger_build(project, version=None, commit=None, record=True, force=False):
+def trigger_build(project, version=None, build=None, commit=None, record=True, force=False):
     """
     Trigger a Build.
 
@@ -213,17 +226,19 @@ def trigger_build(project, version=None, commit=None, record=True, force=False):
     :rtype: tuple
     """
     log.info(
-        'Triggering build. project=%s version=%s commit=%s',
+        'Triggering build. project=%s version=%s commit=%s build=%s',
         project.slug,
         version.slug if version else None,
         commit,
+        build.pk if build else None
     )
     update_docs_task, build = prepare_build(
-        project,
-        version,
-        commit,
-        record,
-        force,
+        project=project,
+        version=version,
+        build=build,
+        commit=commit,
+        record=record,
+        force=force,
         immutable=True,
     )
 

readthedocs/rtd_tests/tests/test_views.py

@@ -263,6 +263,22 @@ def test_build_list_includes_external_versions(self):
         self.assertEqual(response.status_code, 200)
         self.assertIn(external_version_build, response.context['build_qs'])
 
+    @mock.patch('readthedocs.projects.tasks.update_docs_task')
+    def test_build_commit_external_version(self, mock):
+        ver = self.pip.versions.first()
+        ver.commit = 'asd324653546'
+        ver.type = 'external'
+        ver.save()
+        build = get(Build, version=ver, project=self.pip)
+        build.save()
+        r = self.client.post('/projects/pip/builds/',
+            {'version_slug': ver.slug, 'commit': ver.commit, 'build_pk': build.pk}
+        )
+        self.assertEqual(r.status_code, 302)
+        self.assertEqual(
+            r._headers['location'][1],
+            '/projects/pip/builds/%s/' % build.pk,
+        )
 
 class TestSearchAnalyticsView(TestCase):
 

readthedocs/templates/builds/build_detail.html

@@ -69,6 +69,22 @@
           </a>
         </li>
       </div>
+
+
+      {% if request.user|is_admin:project %}
+      <div data-bind="visible: finished()">
+        <form method="post" name="rebuild_commit" action="{% url "builds_project_list" project.slug %}">
+          {% csrf_token %}
+            <a href="#" onclick="document.forms['rebuild_commit'].submit();">
+              Rebuild this build
+            </a>
+            <input type="hidden" name="version_slug" value="{{ build.version.slug }}">
+            <input type="hidden" name="commit" value="{{ build.commit }}">
+            <input type="hidden" name="build_pk" value="{{ build.pk }}">
+        </form>
+      </div>
+      {% endif %}
+
     </ul>
 
     <div class="build-id">