Try to fix annotated tags #6959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'd like to just revert the original -- this keeps getting more complex, and I'm not sure this is actually valuable? How much faster is this than the original code? |
|
@ericholscher the original code opens a file and iterates over till it finds a match for each tag. The complexity grows in This consumes a lot of build time for projects with a lot of tags (and it makes syncs slow too), not sure if the new builders can handle this better. |
|
OK, I guess it makes sense to try and optimize this then 👍 |
ericholscher
approved these changes
Apr 27, 2020
|
Tested this locally, built time is almost the same as before for projects with thousands of tags (< 5 min) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fixes #6932