Report build status in a smarter way #6839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could happen that the person that has imported the project does not have permissions anymore to send Build Status to the social service (e.g. GitHub). In that case, we were just skipping the report to the service completely. On the other hand, if the project didn't have a RemoreRepository, we were trying using all the mantainers' accounts to report the status. This commit uses the same re-trying code, but also when the first attempt using the account of the user that imported the repository, failed.
ericholscher
approved these changes
Mar 31, 2020
|
Hi, where will this be deployed? RTD project I maintain has be affected by this and I was wondering when we will be able to test out if status checks get reported. |
|
@jack1142 hopefully today in a couple of hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could happen that the person that has imported the project does not
have permissions anymore to send Build Status to the social
service (e.g. GitHub).
In that case, we were just skipping the report to the service
completely.
On the other hand, if the project didn't have a RemoreRepository, we
were trying using all the mantainers' accounts to report the status.
This commit uses the same re-trying code, but also when the first
attempt using the account of the user that imported the repository,
failed.
Closes #6686