Skip to content

Do not save pip cache when using CACHED_ENVIRONMENT #6820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Do not save pip cache when using CACHED_ENVIRONMENT #6820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions readthedocs/doc_builder/python_environments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,17 @@ def _pip_cache_cmd_argument(self):

The decision is made considering if the directories are going to be
cleaned after the build (``RTD_CLEAN_AFTER_BUILD=True`` or project has
the ``CLEAN_AFTER_BUILD`` feature enabled) and project has not the
feature ``CACHED_ENVIRONMENT``. In this case, there is no need to cache
the ``CLEAN_AFTER_BUILD`` feature enabled) or project has the feature
``CACHED_ENVIRONMENT``. In this case, there is no need to cache
anything.
"""
if (
(
settings.RTD_CLEAN_AFTER_BUILD or
self.project.has_feature(Feature.CLEAN_AFTER_BUILD)
) and not self.project.has_feature(Feature.CACHED_ENVIRONMENT)
# Cache is going to be removed anyways
settings.RTD_CLEAN_AFTER_BUILD or
self.project.has_feature(Feature.CLEAN_AFTER_BUILD) or
# Cache will be pushed/pulled each time and won't be used because
# packages are already installed in the environment
self.project.has_feature(Feature.CACHED_ENVIRONMENT)
):
return [
'--no-cache-dir',
Expand Down