Do not reset the build start time when running build env #6794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are creating one Setup Environment and another Build Environment. Once each of them is created they define the `start_time` which is UTC now. Then they use the `start_time` to calculate the `length` of the build each time the build object is updated via the API. Since the Build Environment calls again UTC now, we override the old `start_time` and we loose track of the timing for the Setup Environment (close repository, among others). This commit saves the original `start_time` and passes it to the Build Environment so it continues calculating the difference for the `length` considering the Setup Environment times as well.
stsewd
approved these changes
Mar 19, 2020
humitos
added a commit
that referenced
this pull request
Mar 23, 2020
…inning Do not reset the build start time when running build env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are creating one Setup Environment and another Build Environment.
Once each of them is created they define the
start_timewhich is UTCnow. Then they use the
start_timeto calculate thelengthof thebuild each time the build object is updated via the API.
Since the Build Environment calls again UTC now, we override the old
start_timeand we loose track of the timing for the SetupEnvironment (close repository, among others).
This commit saves the original
start_timeand passes it to the BuildEnvironment so it continues calculating the difference for the
lengthconsidering the Setup Environment times as well.Related to #6793