Skip to content

Use the hotfixed version of django-messages-extends #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

davidfischer
Copy link
Contributor

  • This version isn't released yet
  • This is needed to delete these permanent messages in Django 2.2

- This version isn't released yet
- This is needed to delete these permanent messages in Django 2.2
@davidfischer davidfischer requested a review from a team March 10, 2020 18:51
@@ -91,7 +91,8 @@ nltk==3.4.5
textblob==0.15.3

django-annoying==0.10.5
django-messages-extends==0.6.0
# Messages-extends needs a fix for Django 2.2 which isn't released (0.6.1 isn't out yet)
git+https://github.com/AliLozano/django-messages-extends.git@b1e4f4c#egg=django-messages-extends==0.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if because of 0.6.0 this isn't going to get updated, I think we hit something like that in the past

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried it, it seemed to work correctly.

@ericholscher ericholscher merged commit 0261005 into master Mar 11, 2020
@ericholscher ericholscher deleted the davidfischer/django-messages-hotfix branch March 11, 2020 15:25
@ericholscher
Copy link
Member

Added this as QA on the deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants