Drop mock dependency #6723
Merged
Drop mock dependency #6723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of issue: drop mock dependency (readthedocs#6665)
saadmk11
reviewed
Feb 28, 2020
CHANGELOG.rst
Outdated
| @@ -8,6 +8,7 @@ This version has two major changes: | |||
| * It updates our default docker images to stable=5.0 and latest=6.0. | |||
| * It changes our PR builder domain to `readthedocs.build` | |||
|
|
|||
| * `@gallowayj <https://github.com/gallowayj>`__: Drop mock as a dependency (`#6665 <https://github.com/readthedocs/readthedocs.org/pull/6665>`__) | |||
There was a problem hiding this comment.
This is actually auto generated. So, I think we don't need to add this here.
There was a problem hiding this comment.
@saadmk11 Sorry, should I cancel the pull requestion and resubmit a new pull request with the changes add to CHANGELOG.rst?
There was a problem hiding this comment.
No. Just remove this line and push it to the branch and the PR will be updated
There was a problem hiding this comment.
@saadmk11 Thanks, I've removed that line and pushed the changes back to the branch.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped mock as a dependency to resolve issue #6665 by changing imports of mock to unittest.mock and removing mock from requirements.txt.