Skip to content

Remove overriding of object_list in ListView #6678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2020
Merged

Remove overriding of object_list in ListView #6678

merged 3 commits into from
Feb 25, 2020

Conversation

ericholscher
Copy link
Member

I don’t quite know why this was here,
but it definitely broke and this fixes it.

@ericholscher
Remove overriding of object_list in ListView
c5ac7f7 
I don’t quite know why this was here,
but it definitely broke and this fixes it.
ericholscher
ericholscher commented Feb 19, 2020
View reviewed changes
readthedocs/projects/views/private.py
context = super().get_context_data(object_list=object_list, **kwargs)

return context

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was doing nothing, so I removed it.

stsewd
stsewd approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

@stsewd
Copy link
Member

stsewd commented Feb 19, 2020

Looks like linting was the reason this was changed

builds/views.py

  Line: 90

    pylint: arguments-differ / Parameters differ from overridden 'get_context_data' method (col 4)

projects/views/public.py

  Line: 63

    pylint: arguments-differ / Parameters differ from overridden 'get_context_data' method (col 4)

@stsewd
Copy link
Member

stsewd commented Feb 19, 2020

In the signature this inherits from, only kwargs are allowed

https://docs.djangoproject.com/en/2.2/ref/class-based-views/mixins-simple/#django.views.generic.base.ContextMixin.get_context_data

@ericholscher ericholscher changed the base branch from master to rel-django-2 February 25, 2020 15:05
@ericholscher ericholscher changed the base branch from rel-django-2 to master February 25, 2020 15:23
@ericholscher ericholscher merged commit 2c3fd31 into master Feb 25, 2020
@ericholscher ericholscher deleted the fix-django2-upgrade branch February 25, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @stsewd