Skip to content

Use PUBLIC_DOMAIN_USES_HTTPS for resolver tests #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2020
Merged

Use PUBLIC_DOMAIN_USES_HTTPS for resolver tests #6673

merged 3 commits into from
Feb 18, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 18, 2020

Parity with production but also allow to run these tests in corporate.

@humitos
Use PUBLIC_DOMAIN_USES_HTTPS for resolver tests
436c7ac 
Parity with production but also allow to run these tests in corporate.
@humitos humitos requested a review from ericholscher February 18, 2020 14:15
@humitos
Copy link
Member Author

humitos commented Feb 18, 2020

Hrm... it seems the resolver does not respect the setting?

ericholscher
ericholscher approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍 We need to make sure we have SSL configured in prod now, though!

@humitos humitos merged commit 3cee2ce into master Feb 18, 2020
@humitos humitos deleted the humitos/use-https-public branch February 18, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @ericholscher