New docker release (6.0 and testing) #6654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
changed the title
This was referenced Feb 13, 2020
readthedocs/settings/base.py
Outdated
| }, | ||
| 'readthedocs/build:6.0rc1': { | ||
| 'python': {'supported_versions': [2, 2.7, 3, 3.5, 3.6, 3.7, 3.8, 'pypy3.5']}, | ||
| 'readthedocs/build:testing': { |
There was a problem hiding this comment.
I think this should be labeled as 7.0, and testing used as an alias, like latest and stable. I don't think we want a specific testing image, otherwise it's done differently than all our other images.
| }, | ||
| } | ||
|
|
||
| # Alias tagged via ``docker tag`` on the build servers | ||
| DOCKER_IMAGE_SETTINGS.update({ | ||
| 'readthedocs/build:stable': DOCKER_IMAGE_SETTINGS.get('readthedocs/build:4.0'), | ||
| 'readthedocs/build:latest': DOCKER_IMAGE_SETTINGS.get('readthedocs/build:5.0'), | ||
| 'readthedocs/build:stable': DOCKER_IMAGE_SETTINGS.get('readthedocs/build:5.0'), |
There was a problem hiding this comment.
Wouldn't this change everybody who was pointed at stable in their config file to use readthedocs/build:5.0 when previously they were using readthedocs/build:4.0? I'm not super familiar with the backwards compatibility of our docker images but is that what we want?
Mark - 5.0 as stable - 6.0 as latest
ericholscher
force-pushed
the
humitos/new-docker-release
branch
from
224e5b0 to
1c0a502
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0andtestingimages in our YAML file.Edit: this PR includes changes from #6653 so be careful when merging.