Skip to content

Remove re-authing of users on downloads. #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Conversation

ericholscher
Copy link
Member

This was causing an issue on .com.
The allowed_user functionality works with logged in docs users,
whereas the public() queryset method doesn't.

This was causing an issue on .com.
The `allowed_user` functionality works with logged in docs users,
whereas the `public()` queryset method doesn't.
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also override the allowe_user check to respect the privacy level if we want, but we are removing it. I'm +1 on keep everything public in .org

@ericholscher ericholscher merged commit bca92c7 into master Feb 18, 2020
@ericholscher ericholscher deleted the fix-com-downloads branch February 18, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants