Skip to content

Remove webs from broadcast list #6592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 27, 2020

Use an empty list so webs are not called to execute any of the following tasks:

  • syncing files
  • remove directories
  • update metadata

This is a different approach we could use for #6326 and/or #6535 while we test how it works.

Use an empty list so webs are not called to execute any of the
following tasks:

- syncing files
- remove directories
- update metadata
@ericholscher
Copy link
Member

This setting is overridden in prod. We can also just set the FILE_SYNCER setting to the NullSyncer for a similar effect in prod.

@humitos
Copy link
Member Author

humitos commented Jan 28, 2020

This setting is overridden in prod.

Right. This is just a way to share what's the change proposal.

We can also just set the FILE_SYNCER setting to the NullSyncer for a similar effect in prod.

Yes. This is what we are already using in Docker compose setup. Although, tasks are still triggered and symlink code (+ other) is being executed in the web servers.

@ericholscher
Copy link
Member

I worry this might have other effects, given that we're doing a broadcast to nothing, but we depend on the broadcast to actually complete to run the tasks afterwards, so this feels riskier than just null routing the normal broadcasts.

@stale
Copy link

stale bot commented Mar 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Mar 14, 2020
@stale stale bot closed this Mar 21, 2020
@stsewd stsewd deleted the humitos/remove-webs-broadcast branch September 15, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: stale Issue will be considered inactive soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants