Fixes #5388 -- Added Documentation for constraint while using Conda #6509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Jan 9, 2020
|
@stsewd I have made the requested changes, please have a look |
stsewd
reviewed
Jan 9, 2020
stsewd
reviewed
Jan 9, 2020
stsewd
reviewed
Jan 9, 2020
stsewd
reviewed
Jan 14, 2020
…ing Conda This patch adds few notes and warnings in the configuration file documentation, which will warn the user if he/she is using conda enviroment to setup the docs.
humitos
reviewed
Jan 22, 2020
Comment on lines
+123
to
+126
| .. warning:: | ||
|
|
||
| If you are using a :ref:`Conda <config-file/v2:conda>` environment to manage | ||
| the build, this setting will not have any effect, as the Python version is managed by Conda. |
There was a problem hiding this comment.
@stsewd what about making these notes as validation errors when the build is triggered? I feel that it only adds confusion to users the ability to use both at the same time and do not receive any error when building?
There was a problem hiding this comment.
Yeah, we can raise an error in addition to just put it in the docs
There was a problem hiding this comment.
There was a problem hiding this comment.
@Parth1811 thanks for pointing that, didn't remember I wrote that 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds few notes and warnings in the configuration file documentation,
which will warn the user if he/she is using conda enviroment to setup the docs.
Fixes #5388