Skip to content

Support 6.0rc1 build image #6329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 24, 2019

This is basically the same as #6327, with tests fixed.

Users get python 3.8 only if they have python: 3 as version (not if they have python: 3.x) or aren't using a configuration file and have python3 set on the web UI.

readthedocs/readthedocs-docker-images#111 is needed.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

eslint test are failing but it's not related to this PR.

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good 👍

We need an ops PR that adds the image to the build servers. I'll set to block, feel free to unblock once we have that PR merged.

@agjohnson agjohnson added Status: blocked Issue is blocked on another issue and removed Status: blocked Issue is blocked on another issue labels Oct 30, 2019
@humitos humitos merged commit 29f603a into readthedocs:master Oct 31, 2019
@humitos humitos mentioned this pull request Oct 31, 2019
@stsewd stsewd deleted the support-6.0rc1-build-image branch October 31, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants