Don't error on non existing version #6325
Conversation
| if not kwargs['filters']['version']: | ||
| raise ValidationError("Unable to find a version to search") | ||
| log.info("Unable to find a version to search") | ||
| return HTMLFile.objects.none() |
There was a problem hiding this comment.
Some lines below, we are returning a PageSearch object. Shouldn't we return something similar here instead of a different queryset object?
There was a problem hiding this comment.
PageSearch isn't an django model, is an elastic search document based on HTMLFile. Actually it's weird becuase the PagaSearch has an interface similar to what django rest framework expects (there is a comment for that in this class or somewhere else). Also, funny that returning an empty PageSearch doesn't work with django rest framework.
From what I saw, we can return real HTMLFile objects, but that requires a query to the db, so I guess that's why we are not doing that and doing this hacky thing.
There was a problem hiding this comment.
There's also an open issue related to this: #5235
Return an empty response instead. Related sentry issue https://sentry.io/organizations/read-the-docs/issues/902771096/?project=148442&query=is%3Aunresolved++search
stsewd
force-pushed
the
dont-error-on-wrong-input
branch
from
68de6a6 to
4817473
Compare
Return an empty response instead.
Related sentry issue https://sentry.io/organizations/read-the-docs/issues/902771096/?project=148442&query=is%3Aunresolved++search