Do not use --cache-dir for pip if CLEAN_AFTER_BUILD is enabled #6239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Oct 2, 2019
agjohnson
approved these changes
Oct 3, 2019
agjohnson
pushed a commit
that referenced
this pull request
Oct 3, 2019
* Do not use --cache-dir for pip if CLEAN_AFTER_BUILD is enabled * Invert conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid caching
pippackages if we are using CLEAN_AFTER_BUILD.This PR decide when to use
--cache-diror--no-cache-dirbased on this setting.@stsewd what do you think about this? If you think it's OK, I will fix the tests tomorrow.
Related #6236 (comment)