Skip to content

Changing created to modified time #6234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2019
Merged

Changing created to modified time #6234

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
835345f
Changing created to modified time
Iamshankhadeep Oct 2, 2019
1b23d47
Changing what was reuqested
Iamshankhadeep Oct 2, 2019
599a476
Removing obj which is unused
Iamshankhadeep Oct 2, 2019
0b657c3
merging master into changing-created-to-modified branch
Iamshankhadeep Oct 2, 2019
dd8da16
Deleting 'partial_query.created = time'
Iamshankhadeep Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readthedocs/search/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def record_search_query(project_slug, version_slug, query, total_results, time_s
project__slug=project_slug,
version__slug=version_slug,
created__gte=before_10_sec,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should also be changed to modified__gte=before_10_sec.

).order_by('-created')
).order_by('-modified')

# check if partial query exists,
# if yes, then just update the object.
Expand Down Expand Up @@ -210,5 +210,5 @@ def record_search_query(project_slug, version_slug, query, total_results, time_s
version=version,
query=query,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the obj anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but SearchQuery.objects.create this thing is needed right?
okay let me update the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but SearchQuery.objects.create this thing is needed right?

yes

obj.created = time
obj.modified = time
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed.
modified field gets updated automatically.

Also, this can be simplified to

SearchQuery.objects.create(
    project=project,
    version=version,
    query=query,
)

obj.save()