Don't rely on project privacy level for sitemap and robots.txt #6196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the default version privacy level instead
|
I think this probably makes sense, though maybe something we want to figure out in design decision first. I'll block on #6194 for now, as there is some conversation there. The main problem I have with this currently is that project default privacy level is overloaded with function now and we aren't communicating it's usage to users sufficiently yet. |
|
Just want to mention that this may makes sense only in Community. Corporate should probably return 404 when it's a private. |
|
This was already done in #6798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the default version privacy level instead
Ref #2663