Enabling custom 404 subprojects pages #6153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add a test for this change |
stsewd
added
Needed: tests
humitos
requested changes
Nov 18, 2019
There was a problem hiding this comment.
Hi @tapaswenipathak, thanks for your contribution!
I'm not sure to follow how the changes solve the issue that we are facing. Can you explain a little more your proposed solution? In the middleware we are defining rel and subproject but we are doing nothing with them.
|
I'm going to close this PR as stale for now. Feel free to re-open if you consider and I'll be happy to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5557.